fix error handling output for userscripts collector#536
Open
keen99 wants to merge 2 commits intopython-diamond:masterfrom
Open
fix error handling output for userscripts collector#536keen99 wants to merge 2 commits intopython-diamond:masterfrom
keen99 wants to merge 2 commits intopython-diamond:masterfrom
Conversation
another fix for error cases: before: if stderr is returned, but no stdout, we bail out before we report the stderr content - throwing away the error message that may only be reproducible in the conditions of the collector. after: if stderr is returned, log it regardless of if we bail. log it as warning, not error, since it's non-blocking. also removed "skipping" from the proc.returncode - we dont actually bail unless there's no stdout, regardless of return code, so dont tell the user we are.
also update log message for the no stdout case: make it error, not info, since we bail - and log that we skip.
shawnbutts
added a commit
to Netuitive/netuitive-diamond
that referenced
this pull request
Sep 23, 2016
Member
|
Seems like there are some pep8 test fails here, mind fixing those up? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
another fix for error cases:
before: if stderr is returned, but no stdout, we bail out before we report the stderr content - throwing away the error message that may only be reproducible in the conditions of the collector.
after: if stderr is returned, log it regardless of if we bail. log it as warning, not error, since it's non-blocking.
also removed "skipping" from the proc.returncode - we dont actually bail unless there's no stdout, regardless of return code, so dont tell the user we are.